summaryrefslogtreecommitdiff
path: root/tests/test_settings_ui.py
blob: 88905001b9adf1aa979581543d649a80d56564f9 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
"""Tests for the refactored settings dialog UI."""

from pathlib import Path
from unittest.mock import Mock, patch

import pytest
from PySide6 import QtCore, QtWidgets

from tidal_dl_ng.dialog import DialogPreferences
from tidal_dl_ng.ui.dialog_settings import Ui_DialogSettings


@pytest.fixture
def qapp():
    """Create QApplication instance for tests."""
    app = QtWidgets.QApplication.instance()
    if app is None:
        app = QtWidgets.QApplication([])
    yield app
    # Cleanup is handled by pytest-qt if available, otherwise by QApplication


class TestUiDialogSettings:
    """Test the generated UI class."""

    def test_ui_setupui_creates_all_widgets(self, qapp):
        """Test that setupUi creates all expected widgets."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        # Check main structural widgets
        assert hasattr(ui, "lw_categories")
        assert hasattr(ui, "sw_categories")
        assert hasattr(ui, "bb_dialog")

        # Check pages exist
        assert hasattr(ui, "page_flags")
        assert hasattr(ui, "page_quality")
        assert hasattr(ui, "page_numbers")
        assert hasattr(ui, "page_paths")

    def test_ui_list_widget_properties(self, qapp):
        """Test that the categories list widget has correct properties."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        assert ui.lw_categories is not None
        assert isinstance(ui.lw_categories, QtWidgets.QListWidget)
        assert ui.lw_categories.minimumWidth() == 150
        assert ui.lw_categories.maximumWidth() == 200

    def test_ui_stacked_widget_has_all_pages(self, qapp):
        """Test that the stacked widget contains all 4 pages."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        assert ui.sw_categories is not None
        assert isinstance(ui.sw_categories, QtWidgets.QStackedWidget)
        assert ui.sw_categories.count() == 4

    def test_ui_flags_page_widgets(self, qapp):
        """Test that the Flags page contains all expected checkboxes."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        # Test flags group box exists
        assert hasattr(ui, "gb_flags")
        assert ui.gb_flags is not None

        # Test all checkboxes exist
        checkboxes = [
            "cb_video_download",
            "cb_video_convert_mp4",
            "cb_lyrics_embed",
            "cb_lyrics_file",
            "cb_download_delay",
            "cb_extract_flac",
            "cb_metadata_cover_embed",
            "cb_cover_album_file",
            "cb_skip_existing",
            "cb_symlink_to_track",
            "cb_playlist_create",
            "cb_mark_explicit",
            "cb_use_primary_album_artist",
            "cb_download_dolby_atmos",
        ]

        for cb_name in checkboxes:
            assert hasattr(ui, cb_name), f"Missing checkbox: {cb_name}"
            checkbox = getattr(ui, cb_name)
            assert isinstance(checkbox, QtWidgets.QCheckBox)

    def test_ui_quality_page_widgets(self, qapp):
        """Test that the Quality page contains all expected combo boxes."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        # Test choices group box exists
        assert hasattr(ui, "gb_choices")
        assert ui.gb_choices is not None

        # Test all combo boxes exist
        combos = [
            "c_quality_audio",
            "c_quality_video",
            "c_metadata_cover_dimension",
        ]

        for combo_name in combos:
            assert hasattr(ui, combo_name), f"Missing combo box: {combo_name}"
            combo = getattr(ui, combo_name)
            assert isinstance(combo, QtWidgets.QComboBox)

    def test_ui_numbers_page_widgets(self, qapp):
        """Test that the Numbers page contains all expected spin boxes."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        # Test numbers group box exists
        assert hasattr(ui, "gb_numbers")
        assert ui.gb_numbers is not None

        # Test all spin boxes exist
        spinboxes = [
            "sb_album_track_num_pad_min",
            "sb_downloads_concurrent_max",
        ]

        for sb_name in spinboxes:
            assert hasattr(ui, sb_name), f"Missing spin box: {sb_name}"
            spinbox = getattr(ui, sb_name)
            assert isinstance(spinbox, QtWidgets.QSpinBox)

    def test_ui_paths_page_widgets(self, qapp):
        """Test that the Paths page contains all expected line edits and buttons."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        # Test path group box exists
        assert hasattr(ui, "gb_path")
        assert ui.gb_path is not None

        # Test all line edits exist
        line_edits = [
            "le_download_base_path",
            "le_format_track",
            "le_format_video",
            "le_format_album",
            "le_format_playlist",
            "le_format_mix",
            "le_path_binary_ffmpeg",
        ]

        for le_name in line_edits:
            assert hasattr(ui, le_name), f"Missing line edit: {le_name}"
            line_edit = getattr(ui, le_name)
            assert isinstance(line_edit, QtWidgets.QLineEdit)

        # Test buttons exist
        assert hasattr(ui, "pb_download_base_path")
        assert hasattr(ui, "pb_path_binary_ffmpeg")

    def test_ui_dialog_button_box(self, qapp):
        """Test that the dialog has OK and Cancel buttons."""
        dialog = QtWidgets.QDialog()
        ui = Ui_DialogSettings()
        ui.setupUi(dialog)

        assert ui.bb_dialog is not None
        assert isinstance(ui.bb_dialog, QtWidgets.QDialogButtonBox)
        # Check that standard buttons include OK and Cancel
        buttons = ui.bb_dialog.standardButtons()
        assert QtWidgets.QDialogButtonBox.StandardButton.Ok in buttons
        assert QtWidgets.QDialogButtonBox.StandardButton.Cancel in buttons


class TestDialogPreferencesCategories:
    """Test the DialogPreferences category initialization and navigation."""

    @pytest.fixture
    def mock_settings(self):
        """Create a mock Settings object."""
        settings = Mock()
        settings.data = Mock()

        # Set default values for all parameters
        settings.data.lyrics_embed = False
        settings.data.lyrics_file = False
        settings.data.use_primary_album_artist = False
        settings.data.video_download = False
        settings.data.download_dolby_atmos = False
        settings.data.download_delay = False
        settings.data.video_convert_mp4 = False
        settings.data.extract_flac = False
        settings.data.metadata_cover_embed = False
        settings.data.mark_explicit = False
        settings.data.cover_album_file = False
        settings.data.skip_existing = False
        settings.data.symlink_to_track = False
        settings.data.playlist_create = False

        settings.data.download_base_path = str(Path.home())
        settings.data.format_album = "{artist}/{album}"
        settings.data.format_playlist = "Playlists/{name}"
        settings.data.format_mix = "Mixes/{name}"
        settings.data.format_track = "{title}"
        settings.data.format_video = "{title}"
        settings.data.path_binary_ffmpeg = "ffmpeg"

        settings.data.album_track_num_pad_min = 2
        settings.data.downloads_concurrent_max = 3

        settings.data.quality_audio = Mock()
        settings.data.quality_video = Mock()
        settings.data.metadata_cover_dimension = Mock()

        return settings

    @patch.object(DialogPreferences, "exec")
    def test_init_categories_adds_all_items(self, mock_exec, mock_settings, qapp):
        """Test that _init_categories adds all 4 categories to the list."""
        settings_save = QtCore.Signal()

        with patch.object(DialogPreferences, "gui_populate"):
            dialog = DialogPreferences(mock_settings, settings_save)

            # Check that all categories were added
            assert dialog.ui.lw_categories.count() == 4
            assert dialog.ui.lw_categories.item(0).text() == "Flags"
            assert dialog.ui.lw_categories.item(1).text() == "Quality"
            assert dialog.ui.lw_categories.item(2).text() == "Numbers"
            assert dialog.ui.lw_categories.item(3).text() == "Paths & Formats"

    @patch.object(DialogPreferences, "exec")
    def test_init_categories_sets_first_selected(self, mock_exec, mock_settings, qapp):
        """Test that the first category is selected by default."""
        settings_save = QtCore.Signal()

        with patch.object(DialogPreferences, "gui_populate"):
            dialog = DialogPreferences(mock_settings, settings_save)

            # Check that first item is selected
            assert dialog.ui.lw_categories.currentRow() == 0

    @patch.object(DialogPreferences, "exec")
    def test_category_change_switches_page(self, mock_exec, mock_settings, qapp):
        """Test that changing category switches the stacked widget page."""
        settings_save = QtCore.Signal()

        with patch.object(DialogPreferences, "gui_populate"):
            dialog = DialogPreferences(mock_settings, settings_save)

            # Initially on page 0
            assert dialog.ui.sw_categories.currentIndex() == 0

            # Change to category 1 (Quality)
            dialog.ui.lw_categories.setCurrentRow(1)
            assert dialog.ui.sw_categories.currentIndex() == 1

            # Change to category 2 (Numbers)
            dialog.ui.lw_categories.setCurrentRow(2)
            assert dialog.ui.sw_categories.currentIndex() == 2

            # Change to category 3 (Paths & Formats)
            dialog.ui.lw_categories.setCurrentRow(3)
            assert dialog.ui.sw_categories.currentIndex() == 3

            # Back to category 0 (Flags)
            dialog.ui.lw_categories.setCurrentRow(0)
            assert dialog.ui.sw_categories.currentIndex() == 0

    @patch.object(DialogPreferences, "exec")
    def test_on_category_changed_method(self, mock_exec, mock_settings, qapp):
        """Test that _on_category_changed method works correctly."""
        settings_save = QtCore.Signal()

        with patch.object(DialogPreferences, "gui_populate"):
            dialog = DialogPreferences(mock_settings, settings_save)

            # Test method directly
            dialog._on_category_changed(0)
            assert dialog.ui.sw_categories.currentIndex() == 0

            dialog._on_category_changed(1)
            assert dialog.ui.sw_categories.currentIndex() == 1

            dialog._on_category_changed(2)
            assert dialog.ui.sw_categories.currentIndex() == 2

            dialog._on_category_changed(3)
            assert dialog.ui.sw_categories.currentIndex() == 3


class TestDialogPreferencesIntegration:
    """Integration tests for the complete dialog functionality."""

    @pytest.fixture
    def mock_settings(self):
        """Create a mock Settings object with all required attributes."""
        settings = Mock()
        settings.data = Mock()

        # Set all required attributes
        for attr in [
            "lyrics_embed",
            "lyrics_file",
            "use_primary_album_artist",
            "video_download",
            "download_dolby_atmos",
            "download_delay",
            "video_convert_mp4",
            "extract_flac",
            "metadata_cover_embed",
            "mark_explicit",
            "cover_album_file",
            "skip_existing",
            "symlink_to_track",
            "playlist_create",
        ]:
            setattr(settings.data, attr, False)

        for attr in [
            "download_base_path",
            "format_album",
            "format_playlist",
            "format_mix",
            "format_track",
            "format_video",
            "path_binary_ffmpeg",
        ]:
            setattr(settings.data, attr, f"/test/{attr}")

        settings.data.album_track_num_pad_min = 2
        settings.data.downloads_concurrent_max = 3

        settings.data.quality_audio = Mock()
        settings.data.quality_video = Mock()
        settings.data.metadata_cover_dimension = Mock()

        return settings

    @patch.object(DialogPreferences, "exec")
    def test_dialog_structure_is_correct(self, mock_exec, mock_settings, qapp):
        """Test that the complete dialog structure is correctly set up."""
        settings_save = QtCore.Signal()

        with patch.object(DialogPreferences, "gui_populate"):
            dialog = DialogPreferences(mock_settings, settings_save)

            # Check dialog has UI
            assert hasattr(dialog, "ui")
            assert isinstance(dialog.ui, Ui_DialogSettings)

            # Check categories list is populated
            assert dialog.ui.lw_categories.count() == 4

            # Check stacked widget has 4 pages
            assert dialog.ui.sw_categories.count() == 4

            # Check all pages are accessible
            for i in range(4):
                page = dialog.ui.sw_categories.widget(i)
                assert page is not None

    @patch.object(DialogPreferences, "exec")
    def test_navigation_between_all_categories(self, mock_exec, mock_settings, qapp):
        """Test that navigation works correctly between all categories."""
        settings_save = QtCore.Signal()

        with patch.object(DialogPreferences, "gui_populate"):
            dialog = DialogPreferences(mock_settings, settings_save)

            # Navigate through all categories
            for i in range(4):
                dialog.ui.lw_categories.setCurrentRow(i)
                assert dialog.ui.sw_categories.currentIndex() == i

                # Check that the correct page is visible
                current_widget = dialog.ui.sw_categories.currentWidget()
                assert current_widget is not None