summaryrefslogtreecommitdiff
path: root/tests/test_dialog_preferences_integration.py
blob: b7df74df399ca44e940e7206a4629d58031b60ad (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
"""Integration tests for DialogPreferences with the refactored UI."""

from unittest.mock import Mock, patch

import pytest
from PySide6 import QtCore, QtWidgets

from tidal_dl_ng.config import Settings
from tidal_dl_ng.dialog import DialogPreferences


@pytest.fixture
def qapp():
    """Create QApplication instance for tests."""
    app = QtWidgets.QApplication.instance()
    if app is None:
        app = QtWidgets.QApplication([])
    yield app


@pytest.fixture
def mock_settings():
    """Create a mock Settings object with all required attributes."""
    settings = Mock(spec=Settings)
    settings.data = Mock()

    # Boolean flags
    bool_attrs = [
        "lyrics_embed",
        "lyrics_file",
        "use_primary_album_artist",
        "video_download",
        "download_dolby_atmos",
        "download_delay",
        "video_convert_mp4",
        "extract_flac",
        "metadata_cover_embed",
        "mark_explicit",
        "cover_album_file",
        "skip_existing",
        "symlink_to_track",
        "playlist_create",
    ]
    for attr in bool_attrs:
        setattr(settings.data, attr, False)

    # String paths
    path_attrs = [
        "download_base_path",
        "format_album",
        "format_playlist",
        "format_mix",
        "format_track",
        "format_video",
        "path_binary_ffmpeg",
    ]
    for attr in path_attrs:
        setattr(settings.data, attr, f"/test/{attr}")

    # Numeric values
    settings.data.album_track_num_pad_min = 2
    settings.data.downloads_concurrent_max = 3

    # Enum values
    settings.data.quality_audio = Mock()
    settings.data.quality_video = Mock()
    settings.data.metadata_cover_dimension = Mock()

    return settings


class TestDialogPreferencesInitialization:
    """Test DialogPreferences initialization with refactored UI."""

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_dialog_initializes_with_ui(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that DialogPreferences initializes with the new UI."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        assert hasattr(dialog, "ui")
        assert dialog.ui is not None

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_categories_initialized_correctly(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that categories are initialized correctly."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        # Check categories count
        assert dialog.ui.lw_categories.count() == 5

        # Check categories text
        categories = [dialog.ui.lw_categories.item(i).text() for i in range(5)]
        assert "Flags" in categories
        assert "Quality" in categories
        assert "Numbers" in categories
        assert "Paths & Formats" in categories
        assert "Delimiters" in categories

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_first_category_selected_by_default(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that the first category is selected on initialization."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        assert dialog.ui.lw_categories.currentRow() == 0
        assert dialog.ui.sw_categories.currentIndex() == 0


class TestDialogPreferencesCategoryNavigation:
    """Test category navigation functionality."""

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_category_change_updates_page(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that changing category updates the displayed page."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        # Test each category
        for i in range(4):
            dialog.ui.lw_categories.setCurrentRow(i)
            assert dialog.ui.sw_categories.currentIndex() == i

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_on_category_changed_signal_connected(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that the category change signal is properly connected."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        # Verify the connection by changing category programmatically
        initial_page = dialog.ui.sw_categories.currentIndex()
        dialog.ui.lw_categories.setCurrentRow(2)
        new_page = dialog.ui.sw_categories.currentIndex()

        assert initial_page != new_page
        assert new_page == 2

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_navigate_through_all_categories_sequentially(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test sequential navigation through all categories."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        # Navigate forward
        for i in range(4):
            dialog.ui.lw_categories.setCurrentRow(i)
            assert dialog.ui.sw_categories.currentIndex() == i
            assert dialog.ui.lw_categories.currentRow() == i

        # Navigate backward
        for i in range(3, -1, -1):
            dialog.ui.lw_categories.setCurrentRow(i)
            assert dialog.ui.sw_categories.currentIndex() == i
            assert dialog.ui.lw_categories.currentRow() == i


class TestDialogPreferencesWidgetAccess:
    """Test access to widgets through DialogPreferences."""

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_access_flags_checkboxes(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that flag checkboxes are accessible."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        checkbox_names = ["cb_video_download", "cb_lyrics_embed", "cb_skip_existing"]

        for name in checkbox_names:
            checkbox = getattr(dialog.ui, name, None)
            assert checkbox is not None
            assert isinstance(checkbox, QtWidgets.QCheckBox)

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_access_quality_combos(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that quality combo boxes are accessible."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        combo_names = ["c_quality_audio", "c_quality_video", "c_metadata_cover_dimension"]

        for name in combo_names:
            combo = getattr(dialog.ui, name, None)
            assert combo is not None
            assert isinstance(combo, QtWidgets.QComboBox)

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_access_numbers_spinboxes(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that number spinboxes are accessible."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        spinbox_names = ["sb_album_track_num_pad_min", "sb_downloads_concurrent_max"]

        for name in spinbox_names:
            spinbox = getattr(dialog.ui, name, None)
            assert spinbox is not None
            assert isinstance(spinbox, QtWidgets.QSpinBox)

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_access_path_line_edits(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that path line edits are accessible."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        line_edit_names = ["le_download_base_path", "le_format_track", "le_path_binary_ffmpeg"]

        for name in line_edit_names:
            line_edit = getattr(dialog.ui, name, None)
            assert line_edit is not None
            assert isinstance(line_edit, QtWidgets.QLineEdit)


class TestDialogPreferencesPageVisibility:
    """Test that pages are correctly shown/hidden based on category selection."""

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_only_current_page_visible(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that only the current page is visible."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        for i in range(4):
            dialog.ui.lw_categories.setCurrentRow(i)
            current_widget = dialog.ui.sw_categories.currentWidget()

            # Check that the current widget is the expected page
            if i == 0:
                assert current_widget == dialog.ui.page_flags
            elif i == 1:
                assert current_widget == dialog.ui.page_quality
            elif i == 2:
                assert current_widget == dialog.ui.page_numbers
            elif i == 3:
                assert current_widget == dialog.ui.page_paths

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_page_content_accessible_when_selected(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that page content is accessible when the page is selected."""
        settings_save = QtCore.Signal()
        dialog = DialogPreferences(mock_settings, settings_save)

        # Select Flags page
        dialog.ui.lw_categories.setCurrentRow(0)
        assert dialog.ui.gb_flags.isVisibleTo(dialog.ui.page_flags)

        # Select Quality page
        dialog.ui.lw_categories.setCurrentRow(1)
        assert dialog.ui.gb_choices.isVisibleTo(dialog.ui.page_quality)

        # Select Numbers page
        dialog.ui.lw_categories.setCurrentRow(2)
        assert dialog.ui.gb_numbers.isVisibleTo(dialog.ui.page_numbers)

        # Select Paths page
        dialog.ui.lw_categories.setCurrentRow(3)
        assert dialog.ui.gb_path.isVisibleTo(dialog.ui.page_paths)


class TestDialogPreferencesMethodsStillWork:
    """Test that existing DialogPreferences methods still work with new UI."""

    @patch.object(DialogPreferences, "exec")
    @patch.object(DialogPreferences, "gui_populate")
    def test_init_methods_called(self, mock_populate, mock_exec, mock_settings, qapp):
        """Test that initialization methods are called."""
        settings_save = QtCore.Signal()

        with (
            patch.object(DialogPreferences, "_init_checkboxes") as mock_init_cb,
            patch.object(DialogPreferences, "_init_comboboxes") as mock_init_combo,
            patch.object(DialogPreferences, "_init_line_edit") as mock_init_le,
            patch.object(DialogPreferences, "_init_spin_box") as mock_init_sb,
            patch.object(DialogPreferences, "_init_categories") as mock_init_cat,
        ):

            # Instantiate to trigger init methods; no need to keep a variable
            DialogPreferences(mock_settings, settings_save)

            mock_init_cb.assert_called_once()
            mock_init_combo.assert_called_once()
            mock_init_le.assert_called_once()
            mock_init_sb.assert_called_once()
            mock_init_cat.assert_called_once()

    @patch.object(DialogPreferences, "exec")
    def test_on_category_changed_method_exists(self, mock_exec, mock_settings, qapp):
        """Test that _on_category_changed method exists and is callable."""
        settings_save = QtCore.Signal()

        with patch.object(DialogPreferences, "gui_populate"):
            dialog = DialogPreferences(mock_settings, settings_save)

            assert hasattr(dialog, "_on_category_changed")
            assert callable(dialog._on_category_changed)

            # Test calling it doesn't raise an error
            dialog._on_category_changed(0)
            dialog._on_category_changed(1)
            dialog._on_category_changed(2)
            dialog._on_category_changed(3)