diff options
| author | exislow <exislow@users.noreply.github.com> | 2024-12-13 10:16:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-13 10:16:02 +0100 |
| commit | fc32e99907878b8a16e975ccfd0732718c413373 (patch) | |
| tree | 95a853f268ee0ee53e10b8144bf409e952e75b45 /tidal_dl_ng | |
| parent | 079489fc1eb0b67881ed4d01aac845148fc38f89 (diff) | |
| parent | 80419c727e95c7e3e0f21c30f71260cac629a88c (diff) | |
| download | tidal-dl-ng-fc32e99907878b8a16e975ccfd0732718c413373.tar.gz | |
Merge pull request #276 from exislow/267-help-videos-not-downloading
267-help-videos-not-downloading
Diffstat (limited to 'tidal_dl_ng')
| -rw-r--r-- | tidal_dl_ng/download.py | 32 | ||||
| -rw-r--r-- | tidal_dl_ng/gui.py | 3 |
2 files changed, 18 insertions, 17 deletions
diff --git a/tidal_dl_ng/download.py b/tidal_dl_ng/download.py index a5f528b..9098ed1 100644 --- a/tidal_dl_ng/download.py +++ b/tidal_dl_ng/download.py @@ -98,8 +98,8 @@ class Download: def _download( self, media: Track | Video, - stream_manifest: StreamManifest, path_file: pathlib.Path, + stream_manifest: StreamManifest | None = None, ) -> (bool, pathlib.Path): media_name: str = name_builder_item(media) urls: [str] @@ -325,23 +325,25 @@ class Download: self.adjust_quality_video(quality_video) if quality_video else quality_video ) - try: - media_stream: Stream = media.get_stream() - stream_manifest: StreamManifest = media_stream.get_stream_manifest() - except TooManyRequests: - self.fn_logger.exception( - f"Too many requests against TIDAL backend. Skipping '{name_builder_item(media)}'. " - f"Consider to activate delay between downloads." - ) + stream_manifest: StreamManifest | None = None + + if isinstance(media, Track): + try: + media_stream: Stream = media.get_stream() + stream_manifest = media_stream.get_stream_manifest() + except TooManyRequests: + self.fn_logger.exception( + f"Too many requests against TIDAL backend. Skipping '{name_builder_item(media)}'. " + f"Consider to activate delay between downloads." + ) - return False, "" - except Exception: - self.fn_logger.exception(f"Something went wrong. Skipping '{name_builder_item(media)}'.") + return False, "" + except Exception: + self.fn_logger.exception(f"Something went wrong. Skipping '{name_builder_item(media)}'.") - return False, "" + return False, "" - if isinstance(media, Track): - file_extension = media_stream.get_stream_manifest().file_extension + file_extension = stream_manifest.file_extension if self.settings.data.extract_flac and ( stream_manifest.codecs.upper() == Codec.FLAC and file_extension != AudioExtensions.FLAC diff --git a/tidal_dl_ng/gui.py b/tidal_dl_ng/gui.py index 4d3c38a..fffb7d1 100644 --- a/tidal_dl_ng/gui.py +++ b/tidal_dl_ng/gui.py @@ -3,7 +3,6 @@ import sys import time from collections.abc import Callable, Sequence -from PySide6.QtGui import QStandardItem from requests.exceptions import HTTPError from tidalapi.session import LinkLogin @@ -462,7 +461,7 @@ class MainWindow(QtWidgets.QMainWindow, Ui_MainWindow): def populate_tree_result_child( self, item: [Track | Video | Mix | Album | Playlist], index_count_digits: int - ) -> Sequence[QStandardItem]: + ) -> Sequence[QtGui.QStandardItem]: duration: str = "" # TODO: Duration needs to be calculated later to properly fill with zeros. |