diff options
| author | Robert Honz <exislow+github@gmail.com> | 2024-11-06 15:01:18 +0100 |
|---|---|---|
| committer | Robert Honz <exislow+github@gmail.com> | 2024-11-06 15:01:18 +0100 |
| commit | f41d65d7d361e7a9435f486804df33960cce5f51 (patch) | |
| tree | 39e5e27c118fd0422850eebf7c2d716e147dada3 /tidal_dl_ng | |
| parent | a33581dbbbe0a948a9c74a6ef53b326ab2bc7cf1 (diff) | |
| download | tidal-dl-ng-f41d65d7d361e7a9435f486804df33960cce5f51.tar.gz | |
Since TIDAL has remove MQA (`HI_RES`), all traces of MQA have been removed here.
Diffstat (limited to 'tidal_dl_ng')
| -rw-r--r-- | tidal_dl_ng/dialog.py | 1 | ||||
| -rw-r--r-- | tidal_dl_ng/download.py | 4 | ||||
| -rw-r--r-- | tidal_dl_ng/gui.py | 1 | ||||
| -rw-r--r-- | tidal_dl_ng/helper/decryption.py | 3 | ||||
| -rw-r--r-- | tidal_dl_ng/helper/tidal.py | 2 | ||||
| -rw-r--r-- | tidal_dl_ng/model/cfg.py | 6 | ||||
| -rw-r--r-- | tidal_dl_ng/ui/dialog_settings.py | 24 | ||||
| -rw-r--r-- | tidal_dl_ng/ui/dialog_settings.ui | 23 |
8 files changed, 12 insertions, 52 deletions
diff --git a/tidal_dl_ng/dialog.py b/tidal_dl_ng/dialog.py index cfd4e24..23f1dc8 100644 --- a/tidal_dl_ng/dialog.py +++ b/tidal_dl_ng/dialog.py @@ -171,7 +171,6 @@ class DialogPreferences(QtWidgets.QDialog): "download_delay", "video_convert_mp4", "extract_flac", - "downgrade_on_hi_res", ] def gui_populate(self): diff --git a/tidal_dl_ng/download.py b/tidal_dl_ng/download.py index d6b9e15..9bab8e5 100644 --- a/tidal_dl_ng/download.py +++ b/tidal_dl_ng/download.py @@ -211,10 +211,6 @@ class Download: file_extension: str if isinstance(media, Track): - # If hi_res is forbidden in settings and highest track quality is hi_res, downgrade to high_lossless. - if self.settings.data.downgrade_on_hi_res and media.get_stream().audio_quality == Quality.hi_res: - quality_audio = Quality.high_lossless - # If a quality is explicitly set, change it. if quality_audio: quality_audio_old: Quality = self.adjust_quality_audio(quality_audio) diff --git a/tidal_dl_ng/gui.py b/tidal_dl_ng/gui.py index 65429f9..55e2b97 100644 --- a/tidal_dl_ng/gui.py +++ b/tidal_dl_ng/gui.py @@ -618,7 +618,6 @@ class MainWindow(QtWidgets.QMainWindow, Ui_MainWindow): if ( self.settings.data.quality_audio == quality_highest or self.settings.data.quality_audio == Quality.hi_res_lossless - or (self.settings.data.quality_audio == Quality.hi_res and quality_highest == Quality.hi_res) ): quality = quality_highest else: diff --git a/tidal_dl_ng/helper/decryption.py b/tidal_dl_ng/helper/decryption.py index 2fa2ec0..ebb946a 100644 --- a/tidal_dl_ng/helper/decryption.py +++ b/tidal_dl_ng/helper/decryption.py @@ -37,7 +37,8 @@ def decrypt_security_token(security_token: str) -> (str, str): def decrypt_file(path_file_encrypted: str, path_file_destination: str, key: str, nonce: str) -> None: """ - Decrypts an encrypted MQA file given the file, key and nonce + Decrypts an encrypted MQA file given the file, key and nonce. + TODO: Is it really only necessary for MQA of for all other formats, too? """ # Initialize counter and file decryptor diff --git a/tidal_dl_ng/helper/tidal.py b/tidal_dl_ng/helper/tidal.py index aec5320..a85b7f3 100644 --- a/tidal_dl_ng/helper/tidal.py +++ b/tidal_dl_ng/helper/tidal.py @@ -188,8 +188,6 @@ def quality_audio_highest(media: Track | Album) -> Quality: if MediaMetadataTags.hires_lossless in media.media_metadata_tags: quality = Quality.hi_res_lossless - elif MediaMetadataTags.mqa in media.media_metadata_tags: - quality = Quality.hi_res elif MediaMetadataTags.lossless in media.media_metadata_tags: quality = Quality.high_lossless else: diff --git a/tidal_dl_ng/model/cfg.py b/tidal_dl_ng/model/cfg.py index bda0ae9..17a8464 100644 --- a/tidal_dl_ng/model/cfg.py +++ b/tidal_dl_ng/model/cfg.py @@ -36,7 +36,6 @@ class Settings: path_binary_ffmpeg: str = "" metadata_cover_dimension: CoverDimensions = CoverDimensions.Px320 extract_flac: bool = True - downgrade_on_hi_res: bool = False @dataclass_json @@ -59,7 +58,7 @@ class HelpSettings: quality_audio: str = ( 'Desired audio download quality: "LOW" (96kbps), "HIGH" (320kbps), ' '"LOSSLESS" (16 Bit, 44,1 kHz), ' - '"HI_RES" (MQA 24 Bit, 96 kHz), "HI_RES_LOSSLESS" (up to 24 Bit, 192 kHz)' + '"HI_RES_LOSSLESS" (up to 24 Bit, 192 kHz)' ) quality_video: str = 'Desired video download quality: "360", "480", "720", "1080"' # TODO: Describe possible variables. @@ -80,9 +79,6 @@ class HelpSettings: "The dimensions of the cover image embedded into the track. Possible values: 320x320, 640x640x 1280x1280." ) extract_flac: str = "Extract FLAC audio tracks from MP4 containers and save them as `*.flac` (uses FFmpeg)." - downgrade_on_hi_res: bool = ( - "Never download HI_RES (MQA) quality. Downgrade to the next best available quality instead." - ) @dataclass_json diff --git a/tidal_dl_ng/ui/dialog_settings.py b/tidal_dl_ng/ui/dialog_settings.py index 3f45cea..15ac0fe 100644 --- a/tidal_dl_ng/ui/dialog_settings.py +++ b/tidal_dl_ng/ui/dialog_settings.py @@ -1,7 +1,7 @@ ################################################################################ ## Form generated from reading UI file 'dialog_settings.ui' ## -## Created by: Qt User Interface Compiler version 6.7.0 +## Created by: Qt User Interface Compiler version 6.8.0 ## ## WARNING! All changes made in this file will be lost when recompiling UI file! ################################################################################ @@ -26,7 +26,7 @@ class Ui_DialogSettings: def setupUi(self, DialogSettings): if not DialogSettings.objectName(): DialogSettings.setObjectName("DialogSettings") - DialogSettings.resize(640, 682) + DialogSettings.resize(640, 705) sizePolicy = QSizePolicy(QSizePolicy.Policy.Expanding, QSizePolicy.Policy.Expanding) sizePolicy.setHorizontalStretch(100) sizePolicy.setVerticalStretch(100) @@ -131,19 +131,6 @@ class Ui_DialogSettings: self.lv_flags.addLayout(self.lh_flag_3) - self.horizontalLayout = QHBoxLayout() - self.horizontalLayout.setObjectName("horizontalLayout") - self.lv_flag_downgrade_on_hi_res = QVBoxLayout() - self.lv_flag_downgrade_on_hi_res.setObjectName("lv_flag_downgrade_on_hi_res") - self.cb_downgrade_on_hi_res = QCheckBox(self.gb_flags) - self.cb_downgrade_on_hi_res.setObjectName("cb_downgrade_on_hi_res") - - self.lv_flag_downgrade_on_hi_res.addWidget(self.cb_downgrade_on_hi_res) - - self.horizontalLayout.addLayout(self.lv_flag_downgrade_on_hi_res) - - self.lv_flags.addLayout(self.horizontalLayout) - self.lv_main.addWidget(self.gb_flags) self.gb_choices = QGroupBox(DialogSettings) @@ -235,7 +222,7 @@ class Ui_DialogSettings: self.lh_choices_cover_dimension = QHBoxLayout() self.lh_choices_cover_dimension.setObjectName("lh_choices_cover_dimension") - self.lh_choices_cover_dimension.setSizeConstraint(QLayout.SetDefaultConstraint) + self.lh_choices_cover_dimension.setSizeConstraint(QLayout.SizeConstraint.SetDefaultConstraint) self.l_icon_metadata_cover_dimension = QLabel(self.gb_choices) self.l_icon_metadata_cover_dimension.setObjectName("l_icon_metadata_cover_dimension") sizePolicy4.setHeightForWidth(self.l_icon_metadata_cover_dimension.sizePolicy().hasHeightForWidth()) @@ -494,8 +481,8 @@ class Ui_DialogSettings: self.bb_dialog = QDialogButtonBox(DialogSettings) self.bb_dialog.setObjectName("bb_dialog") - self.bb_dialog.setOrientation(Qt.Horizontal) - self.bb_dialog.setStandardButtons(QDialogButtonBox.Cancel | QDialogButtonBox.Ok) + self.bb_dialog.setOrientation(Qt.Orientation.Horizontal) + self.bb_dialog.setStandardButtons(QDialogButtonBox.StandardButton.Cancel | QDialogButtonBox.StandardButton.Ok) self.lv_main.addWidget(self.bb_dialog) @@ -521,7 +508,6 @@ class Ui_DialogSettings: self.cb_lyrics_file.setText(QCoreApplication.translate("DialogSettings", "CheckBox", None)) self.cb_download_delay.setText(QCoreApplication.translate("DialogSettings", "CheckBox", None)) self.cb_extract_flac.setText(QCoreApplication.translate("DialogSettings", "CheckBox", None)) - self.cb_downgrade_on_hi_res.setText(QCoreApplication.translate("DialogSettings", "CheckBox", None)) self.gb_choices.setTitle(QCoreApplication.translate("DialogSettings", "Choices", None)) self.l_icon_skip_existing.setText(QCoreApplication.translate("DialogSettings", "TextLabel", None)) self.l_skip_existing.setText(QCoreApplication.translate("DialogSettings", "TextLabel", None)) diff --git a/tidal_dl_ng/ui/dialog_settings.ui b/tidal_dl_ng/ui/dialog_settings.ui index 962a19f..da0fc4a 100644 --- a/tidal_dl_ng/ui/dialog_settings.ui +++ b/tidal_dl_ng/ui/dialog_settings.ui @@ -7,7 +7,7 @@ <x>0</x> <y>0</y> <width>640</width> - <height>682</height> + <height>705</height> </rect> </property> <property name="sizePolicy"> @@ -184,21 +184,6 @@ </item> </layout> </item> - <item> - <layout class="QHBoxLayout" name="horizontalLayout"> - <item> - <layout class="QVBoxLayout" name="lv_flag_downgrade_on_hi_res"> - <item> - <widget class="QCheckBox" name="cb_downgrade_on_hi_res"> - <property name="text"> - <string>CheckBox</string> - </property> - </widget> - </item> - </layout> - </item> - </layout> - </item> </layout> </widget> </item> @@ -316,7 +301,7 @@ <item> <layout class="QHBoxLayout" name="lh_choices_cover_dimension" stretch="0,0,50"> <property name="sizeConstraint"> - <enum>QLayout::SetDefaultConstraint</enum> + <enum>QLayout::SizeConstraint::SetDefaultConstraint</enum> </property> <item> <widget class="QLabel" name="l_icon_metadata_cover_dimension"> @@ -679,10 +664,10 @@ <item> <widget class="QDialogButtonBox" name="bb_dialog"> <property name="orientation"> - <enum>Qt::Horizontal</enum> + <enum>Qt::Orientation::Horizontal</enum> </property> <property name="standardButtons"> - <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set> + <set>QDialogButtonBox::StandardButton::Cancel|QDialogButtonBox::StandardButton::Ok</set> </property> </widget> </item> |
