summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Honz <exislow+github@gmail.com>2024-05-03 20:31:27 +0200
committerRobert Honz <exislow+github@gmail.com>2024-05-03 20:39:29 +0200
commit26596ddd3252cbd4a791f8459de0fb15fb34d11e (patch)
treead8899375c1a1f5e11b238fc6b11217bdd421ed8
parent7f8912d83bcc92d5a5b74bf228b6ad12ce6067eb (diff)
downloadtidal-dl-ng-26596ddd3252cbd4a791f8459de0fb15fb34d11e.tar.gz
🛠️ Version Dialog: Behavior changed on auto / manual check.
-rw-r--r--tidal_dl_ng/dialog.py9
-rw-r--r--tidal_dl_ng/gui.py11
2 files changed, 13 insertions, 7 deletions
diff --git a/tidal_dl_ng/dialog.py b/tidal_dl_ng/dialog.py
index eb6481a..1dc9038 100644
--- a/tidal_dl_ng/dialog.py
+++ b/tidal_dl_ng/dialog.py
@@ -55,10 +55,12 @@ class DialogVersion(QtWidgets.QDialog):
if not update_available:
self.ui.l_h_version_new.setText("Latest available version:")
+ self.changelog_hide()
+ else:
+ self.ui.l_changelog_details.setText(update_info.release_info)
+ self.ui.pb_download.clicked.connect(lambda: webbrowser.open(update_info.url))
self.ui.l_version_new.setText(update_info.version)
- self.ui.l_changelog_details.setText(update_info.release_info)
- self.ui.pb_download.clicked.connect(lambda: webbrowser.open(update_info.url))
def error_hide(self):
self.ui.l_error.setHidden(True)
@@ -67,6 +69,9 @@ class DialogVersion(QtWidgets.QDialog):
def update_info_hide(self):
self.ui.l_h_version_new.setHidden(True)
self.ui.l_version_new.setHidden(True)
+ self.changelog_hide()
+
+ def changelog_hide(self):
self.ui.l_changelog.setHidden(True)
self.ui.l_changelog_details.setHidden(True)
self.ui.pb_download.setHidden(True)
diff --git a/tidal_dl_ng/gui.py b/tidal_dl_ng/gui.py
index 906d971..aaeaed6 100644
--- a/tidal_dl_ng/gui.py
+++ b/tidal_dl_ng/gui.py
@@ -78,7 +78,7 @@ class MainWindow(QtWidgets.QMainWindow, Ui_MainWindow):
s_tr_results_add_top_level_item: QtCore.Signal = QtCore.Signal(object)
s_settings_save: QtCore.Signal = QtCore.Signal()
s_pb_reload_status: QtCore.Signal = QtCore.Signal(bool)
- s_update_check: QtCore.Signal = QtCore.Signal()
+ s_update_check: QtCore.Signal = QtCore.Signal(bool)
s_update_show: QtCore.Signal = QtCore.Signal(bool, bool, object)
s_queue_download_item_downloading: QtCore.Signal = QtCore.Signal(object)
s_queue_download_item_finished: QtCore.Signal = QtCore.Signal(object)
@@ -291,10 +291,11 @@ class MainWindow(QtWidgets.QMainWindow, Ui_MainWindow):
tree.setContextMenuPolicy(QtCore.Qt.CustomContextMenu)
tree.customContextMenuRequested.connect(self.menu_context_tree_lists)
- def on_update_check(self):
+ def on_update_check(self, on_startup: bool = True):
is_available, info = update_available()
- self.s_update_show.emit(True, is_available, info)
+ if (on_startup and is_available) or not on_startup:
+ self.s_update_show.emit(True, is_available, info)
def apply_settings(self, settings: Settings):
l_cb = [
@@ -624,7 +625,7 @@ class MainWindow(QtWidgets.QMainWindow, Ui_MainWindow):
self.a_version.triggered.connect(self.on_version)
self.a_preferences.triggered.connect(self.on_preferences)
self.a_logout.triggered.connect(self.on_logout)
- self.a_updates_check.triggered.connect(self.on_update_check)
+ self.a_updates_check.triggered.connect(lambda x: self.on_update_check(False))
# Results
self.tr_results.itemExpanded.connect(self.on_tr_results_expanded)
@@ -967,7 +968,7 @@ def gui_activate(tidal: Tidal | None = None):
window = MainWindow(tidal=tidal)
window.show()
# Check for updates
- window.s_update_check.emit()
+ window.s_update_check.emit(True)
sys.exit(app.exec())