summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorexislow <exislow@users.noreply.github.com>2024-11-14 13:12:14 +0100
committerGitHub <noreply@github.com>2024-11-14 13:12:14 +0100
commit16dc6e9133c3fa166982c0e2c27348c84bdd74cb (patch)
tree24495c59450ac40a8860c002b8e8a84db2f17aa3
parentd3dedc0b6f146f09e0afb41d543a46c98d8c1c3b (diff)
parent94382446121458e8b4dd46ebc7133e902f5f2b32 (diff)
downloadtidal-dl-ng-16dc6e9133c3fa166982c0e2c27348c84bdd74cb.tar.gz
Merge pull request #233 from exislow/232-bug-problems-with-metadata-of-high-quality-flac-files-downloaded-from-tidal-via-the-downloader
🛠️ Workaround for wrong extension detection of `tidalapi`. Fixes #232
-rw-r--r--tidal_dl_ng/download.py13
1 files changed, 10 insertions, 3 deletions
diff --git a/tidal_dl_ng/download.py b/tidal_dl_ng/download.py
index 29ca284..46c0beb 100644
--- a/tidal_dl_ng/download.py
+++ b/tidal_dl_ng/download.py
@@ -336,9 +336,16 @@ class Download:
return False, ""
- file_extension = media_stream.get_stream_manifest().file_extension
- # Use M4A extension for MP4 audio tracks, because it looks better and is completely interchangeable.
- file_extension = AudioExtensions.M4A if file_extension == AudioExtensions.MP4 else file_extension
+ # TODO: HOTFIX! Go back to
+ # file_extension = media_stream.get_stream_manifest().file_extension
+ # After tidalapi has fixed #304
+ stream_manifest: StreamManifest = media_stream.get_stream_manifest()
+ if stream_manifest.file_extension is VideoExtensions.TS:
+ file_extension = stream_manifest.file_extension
+ elif AudioExtensions.FLAC in stream_manifest.dash_info.first_url:
+ file_extension = AudioExtensions.FLAC
+ else:
+ file_extension = AudioExtensions.M4A
if self.settings.data.extract_flac and (
media_stream.get_stream_manifest().codecs.upper() == Codec.FLAC