summaryrefslogtreecommitdiff
path: root/tidal_dl_ng
Commit message (Collapse)AuthorAgeFilesLines
* refactor: Improve hover manager cleanup and event filtering logicWarry2025-12-031-19/+26
|
* Merge branch 'feature/json-downloaded' into fusion-refac-&-infoWarry2025-12-0312-212/+2851
|\ | | | | | | | | | | | | # Conflicts: # .gitignore # README.md # tidal_dl_ng/gui.py
| * Merge remote-tracking branch 'warry-github/master' into feature/json-downloadedWarry2025-12-035-15/+28
| |\ | | | | | | | | | | | | # Conflicts: # README.md
| * | feat: Add download history tracking with duplicate preventionWarry2025-11-297-4/+1381
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement comprehensive download history system with JSON persistence and duplicate prevention capabilities. Features: - Persistent JSON-based download history with atomic writes - Duplicate prevention toggle in Tools menu - Thread-safe operations with proper locking - Automatic corruption recovery with backup creation - Import/Export functionality for history portability - Statistics view grouped by source (playlist, album, mix) - Green console messages for improved visibility - Custom exception handling for better error reporting Technical Details: - HistoryService singleton with O(1) track lookups - Track-centric JSON structure for performance - Atomic file operations to prevent data corruption - Custom HistoryFormatError exception class - Complexity reduction through helper methods - Full AGENTS.md compliance (ruff, black, type hints) UI Changes: - Added "Tools" menu with two actions: - "View Download History..." - Opens history dialog - "Prevent Duplicate Downloads" - Toggle with persistence - New Download History dialog with: - Tree view grouped by source - Statistics display - Import/Export buttons - Clear history option - Open folder functionality Files Added: - tidal_dl_ng/history.py (438 lines) - tidal_dl_ng/dialog_history.py (325 lines) - tidal_dl_ng/ui/dialog_history.py - tidal_dl_ng/ui/dialog_history.ui - tests/test_history_service.py (38 tests) - tests/test_download_duplicate_prevention.py (10 tests) - tests/test_gui_duplicate_prevention.py (22 tests) - tests/test_logger_configuration.py (20 tests) - FEATURE_DOCUMENTATION.md (900+ lines) - tests/README.md - CODE_QUALITY_COMPLIANCE.md - FINAL_SUMMARY.md Files Modified: - tidal_dl_ng/download.py - History integration - tidal_dl_ng/gui.py - Tools menu and handlers - tidal_dl_ng/logger.py - Green INFO messages Testing: - 91 tests total, all passing (100% pass rate) - Full test coverage for all new functionality - Thread safety validated with concurrent tests - Corruption recovery tested - Import/Export functionality verified Quality: - Zero ruff violations (full AGENTS.md compliance) - All pre-commit hooks passing - Type hints on all functions - Google-style docstrings throughout - Black formatted - Security reviewed (subprocess usage annotated) Performance: - O(1) track existence checks via dict - Atomic writes prevent corruption - Minimal memory footprint (~100 bytes per track) - Fast startup (<50ms for 1000 tracks) Breaking Changes: None Backward Compatible: Yes (legacy format auto-migrated)
* | | Merge branch 'feature/informations-window' into fusion-refafac-setingsWarry2025-12-0315-1594/+3745
|\ \ \ | | | | | | | | | | | | | | | | # Conflicts: # .gitignore
| * \ \ Merge remote-tracking branch 'warry-github/master' into ↵Warry2025-12-035-15/+28
| |\ \ \ | | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | feature/informations-window # Conflicts: # CONTRIBUTING.md # README.md
| * | | feat: enable rich text links for metadata fields and add search functionalityWarry2025-11-292-78/+175
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Introduced clickable metadata links (tracks, albums, artists, playlists, videos). - Left-click triggers in-app search; Ctrl+click or right-click opens browser search. - Enhanced label interactions and added tooltips for actionable fields. - Simplified artist, album, and playlist rendering with rich links. - Extended search functionality with URL-safe encoding and type mapping.
| * | | fix: correct find_attr calls to use variadic args instead of listWarry2025-11-292-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | After refactoring find_attr signature from list to *args, forgot to update the call sites. Track number and other metadata were not displaying due to passing list instead of individual arguments.
| * | | feat(hover): add track details preview on hover + fix all ruff violationsWarry2025-11-2915-1589/+3643
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement comprehensive track information display on hover and resolve all code quality issues to achieve complete ruff compliance. MAJOR FEATURES: - Track details preview on hover with rich metadata display - Async BPM fetching with loading indicator - Enhanced metadata utilities with fuzzy matching - TIDAL API extras integration FILES MODIFIED: 15+ files (core, UI, tests, docs) RUFF COMPLIANCE: 0 errors (89+ violations resolved) - Fixed E999 syntax error in metadata_utils.py - Refactored 10+ complex functions (C901) - Updated error handling (S110, S112, SIM105) - Modernized type hints (UP038) - Fixed naming conflicts (A001, F811) BUG FIXES: - Added missing _on_update_cover() method (11 test failures) - Fixed BPM display and async loading - Improved thread safety TESTING: 30 passed, 1 skipped DOCUMENTATION: Windows PowerShell support, tox troubleshooting
* | | Merge remote-tracking branch 'warry-github/master' into ↵Warry2025-12-035-15/+28
|\ \ \ | | |/ | |/| | | | feature/refactor-settings-ui
| * | Merge pull request #668 from jotalevi/hide-ffmpeg-flashexislow2025-11-291-0/+14
| |\ \ | | | | | | | | fix(ffmpeg): prevent terminal window flash on Windows during media conversion
| | * | fix(ffmpeg): prevent terminal window flash on Windows during media conversionE.J. Talevi2025-11-262-2/+12
| | | |
| | * | fix(ffmpeg): prevent terminal window flash on Windows during media conversionE.J. Talevi2025-11-262-2/+6
| | |/
| * / Added clarity and grammar fixes to documentation and to some strings on the ↵E.J. Talevi2025-11-255-15/+14
| |/ | | | | | | program itself.
* / feat: refactor settings UI with category navigation and add Delimiters pageWarry2025-11-303-837/+1598
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #640 ## Changes ### UI Refactoring - Replace monolithic settings dialog with category-based navigation - Add QListWidget (lw_categories) for category selection on the left - Add QStackedWidget (sw_categories) for content pages on the right - Organize settings into 5 distinct pages: - Flags (14 checkboxes) - Quality (3 combo boxes) - Numbers (2 spin boxes) - Paths & Formats (7 line edits + 2 browse buttons) - Delimiters (4 line edits) — NEW ### New Feature: Delimiters Category - Add customizable separators for artists in metadata and filenames: - metadata_delimiter_artist - metadata_delimiter_album_artist - filename_delimiter_artist - filename_delimiter_album_artist - Auto-integration with DialogPreferences via parameters_line_edit - Line edits with max width 100px for compact display ### Styling - Apply dark theme to settings dialog: - Category list: #2b2b2b background, #3d5a80 selection, #3a3a3a hover - Settings area: #333333 background, styled GroupBoxes (#3a3a3a) - Light text (#e0e0e0) for better contrast - Add spacing property (6px) to category list for better readability - Style QListWidget items with padding (4px 3px) and margin (2px 0px) ### Testing - Add comprehensive test suite (61 tests total): - test_settings_ui.py: UI and basic integration (14 tests) - test_settings_dialog_structure.py: detailed structure validation (20 tests) - test_dialog_preferences_integration.py: DialogPreferences integration (14 tests) - test_delimiters_category.py: new Delimiters page validation (13 tests) - Fix ruff issues (F841, S108) in test files - All tests passing with 100% success rate ### Documentation - Add docs/refactor_settings_ui.md: comprehensive refactor overview - Add docs/delimiters_category.md: Delimiters feature documentation - Add docs/ui_styles.md: dark theme style guide - Add docs/testing_summary.md: testing overview and commands ### Code Quality - Apply ruff/black/pyupgrade via pre-commit hooks - Fix F841 (unused variable) in test_dialog_preferences_integration.py - Fix S108 (insecure temp path) using Path.home() in test_settings_ui.py - End-of-file fixes applied automatically ## Files Modified - tidal_dl_ng/ui/dialog_settings.ui (complete restructure) - tidal_dl_ng/ui/dialog_settings.py (auto-generated from .ui) - tidal_dl_ng/dialog.py (add 4 delimiter params + Delimiters category) - tests/* (4 new test files with 61 tests) - docs/* (4 new documentation files) ## Impact - Improved UX: intuitive category navigation, better visual organization - Extensibility: easy to add new settings pages/categories - Quality: comprehensive test coverage ensures robustness - User flexibility: customizable separators for metadata and filenames ## Technical Notes - QStackedWidget pages indexed 0-4 matching category list order - Navigation via QListWidget::currentRowChanged signal - Automatic save/load through existing DialogPreferences methods - No breaking changes to existing settings or configuration ## Testing Commands ```powershell poetry run pre-commit run -a poetry run pytest -q
* feat(media): ✨ add support for retrieving album and track artist IDsRobert Honz2025-11-131-0/+4
| | | | | * Implemented logic to return `album_artist_id` for `Album` instances. * Added functionality to retrieve `track_artist_id` for `Track` instances.
* refactor(downloader): 🔧 reorganize TrackStreamInfo class and importsRobert Honz2025-11-132-12/+12
| | | | | | * Moved `TrackStreamInfo` class definition from `download.py` to `downloader.py`. * Removed redundant `dataclass` import from `download.py`. * Updated import statements to maintain clarity and organization.
* Merge pull request #626 from Rikrdoga:Dolby_Atmosexislow2025-11-132-48/+176
|\ | | | | Fix(Atmos): Resolve Race Condition and Optimize Session Switching for Atmos Downloads
| * Create TrackStreamInfo dataclass & Add proper docstringsRikrdoga2025-11-122-13/+52
| |
| * Resolve Race Condition and Optimize Session Switching for Atmos DownloadsRikrdoga2025-11-042-44/+133
| |
* | feat(gui): ✨ add functionality to download albums from favoritesRobert Honz2025-11-121-0/+115
| | | | | | | | | | | | - Introduced a new context menu option to download all albums from selected favorites. - Implemented methods to handle downloading albums from favorite albums, artists, and tracks. - Enhanced logging for better tracking of the download process and errors.
* | feat(gui): ✨ add favorites download functionalityRobert Honz2025-11-121-0/+50
| | | | | | | | | | | | * Implemented `on_download_favorites` method to allow users to download all items from a favorites category. * Added context menu option for downloading all items from favorites. * Enhanced error handling and logging for better user feedback.
* | feat(gui): ✨ add folder support for media downloadsRobert Honz2025-11-121-5/+163
| | | | | | | | | | | | * Implemented context menu options for downloading playlists and albums from folders. * Added methods to fetch playlists and tracks from a folder. * Enhanced user experience by allowing bulk downloads from folder structures.
* | feat(gui): ✨ enhance user media handling with folder supportRobert Honz2025-11-123-53/+255
| | | | | | | | | | | | * Updated `user_media_lists` to return a dictionary containing both `playlists` and `mixes`, including `Folder` objects. * Modified `on_populate_tree_lists` to handle `Folder` items and display their contents. * Introduced new methods for loading and displaying folder contents in the user interface.
* | chore: 🔧 update function names in FAVORITES for consistencyRobert Honz2025-11-121-3/+3
| | | | | | | | | | * Changed `function_name` for `fav_tracks`, `fav_artists`, and `fav_albums` to use paginated versions. * Ensures uniformity in function naming across favorites.
* | Merge pull request #625 from talios/feature/klrrwxuwvrtyexislow2025-11-121-0/+5
|\ \ | |/ |/| Add format place holder for album_type
| * Add format place holder for album_typeMark Derricutt2025-11-051-0/+5
| | | | | | | | | | | | | | | | This commit exposes the album type as a configuration placeholder. Fixes #595 Change-Id: Ife8832534861fc01da5d68c37be6c7476a6a6964
* | Fix album_artist substitutionJeff Brower2025-10-261-2/+2
|/ | | | | For albums that are listed with a non-"main" artist first (ex: 37691520), the album artist replacement was returning an empty string. This isn't a problem with the default settings, but if you format albums into `{album_artist}/...`, the path becomes `/...` in this case, and is interpreted as an absolute path instead of a relative one, causing the download to fail. This changes the logic so that if the `first_only` flag is passed, it will return after the first artist is actually added to the list, no longer returning an empty string.
* chore(gui): 🎨 update data file inclusion pattern for iconsRobert Honz2025-10-221-1/+1
| | | | | * Adjusted the pattern for including icon files to ensure proper matching. * This change enhances the flexibility of file inclusion during the build process.
* chore(ui): 🎨 update application icons for improved visual consistencyRobert Honz2025-10-228-0/+0
| | | | | * Replaced multiple icon files in the UI. * Ensured all icon sizes are updated to maintain a cohesive look across the application.
* refactor(gui): ✨ update album download options and improve session validationRobert Honz2025-10-224-39/+51
| | | | | | * Added a new action to download all albums in a playlist. * Removed the deprecated `validate_session` method and replaced it with a direct call to `self.tidal.session.check_login()`. * Adjusted the UI layout in `dialog_settings` to accommodate new options and improved sizing.
* Merge pull request #596 from Winman486/fix/rate-limiting-playlist-downloadsexislow2025-10-227-6/+279
|\ | | | | Fix/rate limiting playlist downloads
| * refactor: Make rate limiting configurable and move session validation to ↵Winman4862025-10-213-21/+37
| | | | | | | | | | | | | | | | | | | | | | Tidal class - Add api_rate_limit_batch_size and api_rate_limit_delay_sec to Settings (cfg.py) - Move validate_session() and is_authentication_error() to Tidal class (config.py) - Update _load_albums_with_rate_limiting() to use config values instead of hardcoded 20/3 - Update _handle_album_load_error() to use Tidal.is_authentication_error() - Remove _validate_session() from gui.py (now uses Tidal.validate_session()) - Addresses maintainer feedback: configurable tweaking variables and proper separation of concerns
| * fix: Remove duplicate menu entry and reduce code complexityWinman4862025-10-201-69/+131
| | | | | | | | | | | | | | - Removed duplicate 'Download Full Album' context menu entry - Refactored on_download_all_albums_from_playlist to reduce C901 complexity - Extracted helper methods: _extract_album_ids_from_tracks, _load_albums_with_rate_limiting, _validate_session, _handle_album_load_error, _queue_loaded_albums - All make check errors and warnings now resolved
| * Merge upstream/master and resolve conflictsWinman4862025-10-207-96/+111
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | - Resolved conflict in dialog_settings.py (kept both cb_use_primary_album_artist and cb_mark_explicit checkboxes) - Fixed code quality issues found by make check: * Removed duplicate on_download_album_from_track function (F811) * Updated isinstance calls to use X | Y syntax instead of (X, Y) (UP038) * Fixed unused loop variable album_stub (B007) * Applied automatic formatting fixes (black, prettier, trailing whitespace) - Only remaining issue is C901 complexity warning in on_download_all_albums_from_playlist (expected per maintainer feedback)
| * | feat(gui): add rate limiting to Download All Albums feature - Process 20 ↵Winman4862025-10-171-5/+47
| | | | | | | | | | | | albums at a time with 3-second delays - Add session validity checks to prevent OAuth errors - Handle unavailable albums gracefully - Add informative logging for rate limiting progress
| * | feat(gui): add 'Download Full Album', 'Download All Albums', and 'Single ↵Winman4862025-10-176-5/+204
| | | | | | | | | | | | album folder (primary artist)' preference
* | | Merge pull request #573 from Rikrdoga/Dolby_Atmosexislow2025-10-228-11/+107
|\ \ \ | | | | | | | | Implement Dolby Atmos Support & API Key Selection
| * | | Move credentials to constants, improve docs (tidal_obj), and clean up Atmos ↵Rikrdoga2025-10-215-22/+23
| | | | | | | | | | | | | | | | legacy code
| * | | minor fix: Respect audio quality selectedRikrdoga2025-10-201-1/+0
| | | |
| * | | Apply formatter and fix TRY003Rikrdoga2025-10-203-9/+7
| | | |
| * | | Refactor Dolby Atmos ImplementationRikrdoga2025-10-206-71/+83
| | | |
| * | | Refactor Dolby Atmos feature to be internal and seamlessRikrdoga2025-10-207-109/+346
| | | |
| * | | Disable Load from gist and fix JSON in api.py (remove // Invalid)Rikrdoga2025-10-201-16/+16
| | | |
| * | | Add support for Dolby AtmosRikrdoga2025-10-205-244/+93
| | |/ | |/|
* / | fix(gui): 🐛 integrate `ansi2html` for improved log message formattingRobert Honz2025-10-211-5/+7
|/ / | | | | | | | | | | * Added `Ansi2HTMLConverter` to convert ANSI color codes in log messages to HTML. * Updated the `MainWindow` class to utilize the new converter for displaying logs. * Removed dependency on `coloredlogs.converter` for log message display.
* | fix(gui): 🐛 improve album download action and update docstringRobert Honz2025-10-201-5/+10
| | | | | | | | | | * Refactored the menu action for downloading the full album from a track. * Enhanced the docstring for `on_download_album_from_track` to clarify its functionality and error handling.
* | Merge pull request #590 from Rikrdoga/feature/download-album-from-trackexislow2025-10-201-0/+38
|\ \ | | | | | | feat: Add 'Download Full Album' from track context menu
| * | feat: Add 'Download Full Album' from track context menuRikrdoga2025-10-171-0/+38
| |/
* | fix(cfg): 🐛 update `mark_explicit` default value and improve help textRobert Honz2025-10-202-205/+168
| | | | | | | | | | * Set default value of `mark_explicit` to `False`. * Update help text to clarify that marking explicit tracks applies only to metadata.
generated by cgit v1.3.1 (git 2.54.0) at 2026-10-17 07:02:53 +0000